[webkit-reviews] review granted: [Bug 171532] Leaks always reports "WebKit Malloc Memory Pressure Handler" dispatch_queue/source as leaking : [Attachment 309225] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 171532: Leaks always reports "WebKit Malloc Memory Pressure Handler"
dispatch_queue/source as leaking
https://bugs.webkit.org/show_bug.cgi?id=171532

Attachment 309225: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=309225&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 309225
  --> https://bugs.webkit.org/attachment.cgi?id=309225
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=309225&action=review

r=me

> Source/bmalloc/bmalloc/Heap.cpp:61
> +    dispatch_resume(m_pressureHandlerDispatchSource);

I guess you should dispatch_release queue here, since we're behaving as if
we're not leaking these objects.