[webkit-reviews] review denied: [Bug 169421] Implement PlatformWebView::windowSnapshotImage and createBitmapContextFromWebView for iOS devices : [Attachment 309183] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied  review:
Bug 169421: Implement PlatformWebView::windowSnapshotImage and
createBitmapContextFromWebView for iOS devices
https://bugs.webkit.org/show_bug.cgi?id=169421

Attachment 309183: Patch

https://bugs.webkit.org/attachment.cgi?id=309183&action=review




--- Comment #23 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 309183
  --> https://bugs.webkit.org/attachment.cgi?id=309183
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309183&action=review

> Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:266
> +    [m_view
> +	   takeSnapshotWithConfiguration:snapshotConfiguration.get()

Don't split this here.

>> LayoutTests/platform/ios/TestExpectations:2960
>> +compositing/regions/position-layers-inside-regions-overflow-hidden.html [
ImageOnlyFailure ]
> 
> You should talk to Simon about these.
> 
> Otherwise, maybe split this into the completely non-contentious part (and use
my review for that) and make a new patch for the other bit.

These need to go into a device-specific TE file.