[webkit-reviews] review requested: [Bug 171745] WebKit should maintain colorspaces that it understands on NSColors : [Attachment 309201] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has asked	for review:
Bug 171745: WebKit should maintain colorspaces that it understands on NSColors
https://bugs.webkit.org/show_bug.cgi?id=171745

Attachment 309201: Patch

https://bugs.webkit.org/attachment.cgi?id=309201&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 309201
  --> https://bugs.webkit.org/attachment.cgi?id=309201
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309201&action=review

> Source/WebCore/platform/graphics/mac/ColorMac.mm:64
> +    if (color.colorSpace == [NSColorSpace sRGBColorSpace])

This should use isEqual(To?): right?

> Source/WebCore/platform/graphics/mac/ColorMac.mm:67
> +	   rgbColor = [color colorUsingColorSpaceName:NSDeviceRGBColorSpace];

Is this equivalent to NSCalibratedRGBColorSpace and which is sRGB?