[webkit-reviews] review granted: [Bug 171745] WebKit should maintain colorspaces that it understands on NSColors : [Attachment 309201] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 5 13:36:30 PDT 2017
Tim Horton <thorton at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 171745: WebKit should maintain colorspaces that it understands on NSColors
https://bugs.webkit.org/show_bug.cgi?id=171745
Attachment 309201: Patch
https://bugs.webkit.org/attachment.cgi?id=309201&action=review
--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 309201
--> https://bugs.webkit.org/attachment.cgi?id=309201
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=309201&action=review
> Source/WebCore/platform/graphics/mac/ColorMac.mm:64
> + if (color.colorSpace == [NSColorSpace sRGBColorSpace])
Please use isEqual.
More information about the webkit-reviews
mailing list