[webkit-reviews] review granted: [Bug 169421] Implement PlatformWebView::windowSnapshotImage and createBitmapContextFromWebView for iOS devices : [Attachment 309183] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 169421: Implement PlatformWebView::windowSnapshotImage and
createBitmapContextFromWebView for iOS devices
https://bugs.webkit.org/show_bug.cgi?id=169421

Attachment 309183: Patch

https://bugs.webkit.org/attachment.cgi?id=309183&action=review




--- Comment #22 from Tim Horton <thorton at apple.com> ---
Comment on attachment 309183
  --> https://bugs.webkit.org/attachment.cgi?id=309183
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309183&action=review

> LayoutTests/platform/ios/TestExpectations:2960
> +compositing/geometry/clipped-out-perspective.html [ ImageOnlyFailure ]
> +compositing/hidpi-subpixel-transform-origin.html [ ImageOnlyFailure ]
> +compositing/regions/position-layer-inside-region-overflow-hidden.html [
ImageOnlyFailure ]
> +compositing/regions/position-layers-inside-region-overflow-hidden.html [
ImageOnlyFailure ]
> +compositing/regions/position-layers-inside-regions-overflow-hidden.html [
ImageOnlyFailure ]

You should talk to Simon about these.

Otherwise, maybe split this into the completely non-contentious part (and use
my review for that) and make a new patch for the other bit.