[webkit-reviews] review granted: [Bug 171737] Move trivial String prototype functions to JS builtins : [Attachment 309195] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 5 12:37:06 PDT 2017


Saam Barati <sbarati at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 171737: Move trivial String prototype functions to JS builtins
https://bugs.webkit.org/show_bug.cgi?id=171737

Attachment 309195: Patch

https://bugs.webkit.org/attachment.cgi?id=309195&action=review




--- Comment #12 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 309195
  --> https://bugs.webkit.org/attachment.cgi?id=309195
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309195&action=review

> Source/JavaScriptCore/builtins/StringPrototype.js:324
> +    return p4;

Maybe use a template literal for these last 3 concatenations?


More information about the webkit-reviews mailing list