[webkit-reviews] review granted: [Bug 171591] putDirectIndex does not properly do defineOwnProperty : [Attachment 309017] patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 171591: putDirectIndex does not properly do defineOwnProperty
https://bugs.webkit.org/show_bug.cgi?id=171591

Attachment 309017: patch

https://bugs.webkit.org/attachment.cgi?id=309017&action=review




--- Comment #24 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 309017
  --> https://bugs.webkit.org/attachment.cgi?id=309017
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309017&action=review

r=me

> Source/JavaScriptCore/bytecode/ByValInfo.h:180
> +    default:
> +	   return false;

This default includes JITDirectArguments and JITScopedArguments, but your
comment only covers typed arrays. Was it intentional to include
JITDirectArguments and JITScopedArguments in forbidding PutDirect? If so, I
would mention that, and why.