[webkit-reviews] review granted: [Bug 171717] ASSERTION FAILED: !frame().document()->inRenderTreeUpdate() in WebCore::FrameView::layout(bool) : [Attachment 309152] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 5 08:33:33 PDT 2017


Brent Fulgham <bfulgham at webkit.org> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 171717: ASSERTION FAILED: !frame().document()->inRenderTreeUpdate() in
WebCore::FrameView::layout(bool)
https://bugs.webkit.org/show_bug.cgi?id=171717

Attachment 309152: patch

https://bugs.webkit.org/attachment.cgi?id=309152&action=review




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 309152
  --> https://bugs.webkit.org/attachment.cgi?id=309152
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309152&action=review

lgtm. r=me.

> Source/WebCore/loader/FrameLoader.cpp:796
> +    // FIXME: It would be better if resource loads were kicked off after
render tree update (or didn't complete synchronously).

Can you file a Bugzilla for this and include the number here?


More information about the webkit-reviews mailing list