[webkit-reviews] review granted: [Bug 171708] GCController.cpp's collect() should be Async : [Attachment 309128] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 4 19:47:54 PDT 2017


Saam Barati <sbarati at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 171708: GCController.cpp's collect() should be Async
https://bugs.webkit.org/show_bug.cgi?id=171708

Attachment 309128: the patch

https://bugs.webkit.org/attachment.cgi?id=309128&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 309128
  --> https://bugs.webkit.org/attachment.cgi?id=309128
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309128&action=review

> Source/WebCore/bindings/js/GCController.cpp:44
> +    commonVM().heap.collectNow(Async, CollectionScope::Full);

nit: I still think this should've been an enum class. It scares me that we have
top level Sync/Async enum values in JSC.


More information about the webkit-reviews mailing list