[webkit-reviews] review granted: [Bug 171701] [Mac] Modernize image for dragged link : [Attachment 309118] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted  review:
Bug 171701: [Mac] Modernize image for dragged link
https://bugs.webkit.org/show_bug.cgi?id=171701

Attachment 309118: patch

https://bugs.webkit.org/attachment.cgi?id=309118&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 309118
  --> https://bugs.webkit.org/attachment.cgi?id=309118
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309118&action=review

> Source/WebCore/platform/mac/DragImageMac.mm:161
> +const float linkImagePadding = 10; // Keep in sync with
DragController::LinkDragBorderInset.
> +const float linkImageDomainBaselineToTitleBaseline = 18;
> +const float linkImageCornerRadius = 5;
> +const float linkImageMaximumWidth = 400;
> +const float linkImageFontSize = 11;

Some of these should be CGFloats.

> Source/WebCore/platform/mac/DragImageMac.mm:176
> +    void layOutText(NSString *text, NSColor *, NSFont *, CFIndex
maximumLines, CTLineTruncationType, CGFloat& maximumAvailableWidth, CGFloat&
maximumUsedTextWidth, CGFloat& currentY);

layOutText is hard on my eyes.