[webkit-reviews] review requested: [Bug 171690] JSC::Heap should expose a richer API for requesting GCs : [Attachment 309101] the patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has asked  for review:
Bug 171690: JSC::Heap should expose a richer API for requesting GCs
https://bugs.webkit.org/show_bug.cgi?id=171690

Attachment 309101: the patch

https://bugs.webkit.org/attachment.cgi?id=309101&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 309101
  --> https://bugs.webkit.org/attachment.cgi?id=309101
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309101&action=review

> Source/JavaScriptCore/heap/Heap.cpp:984
> +    } }

style nit: I think there should be a newline between braces here.

> Source/JavaScriptCore/heap/Heap.cpp:997
> +	       if (request.subsumedBy(request)) {

This confuses me. Why are we calling subsumedBy always passing in the self
object?

> Source/JavaScriptCore/heap/Synchronousness.h:30
> +enum Synchronousness {

style nit: How about an enum class here since this only used in a handful of
locations