[webkit-reviews] review granted: [Bug 171592] Add mute to WebPlaybackSessionModel. : [Attachment 309102] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 171592: Add mute to WebPlaybackSessionModel.
https://bugs.webkit.org/show_bug.cgi?id=171592

Attachment 309102: Patch

https://bugs.webkit.org/attachment.cgi?id=309102&action=review




--- Comment #7 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 309102
  --> https://bugs.webkit.org/attachment.cgi?id=309102
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309102&action=review

> Source/WebCore/platform/ios/WebAVPlayerController.mm:433
> +    UNUSED_PARAM(sender);
> +    if (!self.delegate)
> +	   return;
> +    self.delegate->toggleMuted();

Nit: this could probably just drop the ! from the if and skip the return.