[webkit-reviews] review granted: [Bug 171588] Make the [EnabledBySetting] extended attribute work for any attribute or operation on a prototype : [Attachment 308876] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 4 10:55:04 PDT 2017
Dean Jackson <dino at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 171588: Make the [EnabledBySetting] extended attribute work for any
attribute or operation on a prototype
https://bugs.webkit.org/show_bug.cgi?id=171588
Attachment 308876: Patch
https://bugs.webkit.org/attachment.cgi?id=308876&action=review
--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 308876
--> https://bugs.webkit.org/attachment.cgi?id=308876
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=308876&action=review
> Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:2891
> +}
> +
> +#endif
Nit: the #if had no blank line before the code.
> Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4564
> +
> +#endif
ditto
More information about the webkit-reviews
mailing list