[webkit-reviews] review granted: [Bug 171627] messages_unittest.py should support an [-r|--reset-results] switch : [Attachment 309036] Patch v3

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 171627: messages_unittest.py should support an [-r|--reset-results] switch
https://bugs.webkit.org/show_bug.cgi?id=171627

Attachment 309036: Patch v3

https://bugs.webkit.org/attachment.cgi?id=309036&action=review




--- Comment #10 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 309036
  --> https://bugs.webkit.org/attachment.cgi?id=309036
Patch v3

View in context: https://bugs.webkit.org/attachment.cgi?id=309036&action=review

r=me

> Source/WebKit2/ChangeLog:8
> +	   This change adds support for an [-r|--reset-reesults] switch

an => a
--reset-reesults => --reset-results

> Source/WebKit2/ChangeLog:52
> +	   - Parses [-r|--reset-results] switch, and then remove it from

remove => removes

> Source/WebKit2/Scripts/webkit/messages_unittest.py:357
> +	   if arg in ('-r', '--r', '--reset', '--reset-results') or
'--reset-results'.startswith(arg):

Wow, this is pretty generous parsing. I wish there was a way to make this
option discoverable.