[webkit-reviews] review granted: [Bug 171510] check-webkit-style exits with an error while parsing Source/WebKit2/Scripts/webkit/ directory: KeyError: 'st' : [Attachment 308894] Patch v1

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 171510: check-webkit-style exits with an error while parsing
Source/WebKit2/Scripts/webkit/ directory: KeyError: 'st'
https://bugs.webkit.org/show_bug.cgi?id=171510

Attachment 308894: Patch v1

https://bugs.webkit.org/attachment.cgi?id=308894&action=review




--- Comment #11 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 308894
  --> https://bugs.webkit.org/attachment.cgi?id=308894
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=308894&action=review

> Source/WebKit2/ChangeLog:8
> +	   The problem was that 'import parser' was abiguous since there is

abiguous => ambiguous

> Source/WebKit2/ChangeLog:9
> +	   a built-in parser module that comes with python.  Changing

python => Python

> Source/WebKit2/ChangeLog:19
> +	   As an added bonus, this patch also fixes all webkit-style issues
> +	   in Source/WebKit2/Scripts/webkit/*.py files.

Yay!