[webkit-reviews] review granted: [Bug 171633] Add support for reading and writing settings from UIProcess audio capture : [Attachment 308991] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 3 17:38:29 PDT 2017
Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 171633: Add support for reading and writing settings from UIProcess audio
capture
https://bugs.webkit.org/show_bug.cgi?id=171633
Attachment 308991: Patch
https://bugs.webkit.org/attachment.cgi?id=308991&action=review
--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 308991
--> https://bugs.webkit.org/attachment.cgi?id=308991
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=308991&action=review
> Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:306
>
Nit: extra blank
> Source/WebKit2/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:147
> + settings = source->settings();
Why is this necessary?
More information about the webkit-reviews
mailing list