[webkit-reviews] review requested: [Bug 168939] Make ImageDiff stand-alone : [Attachment 308978] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has asked  for review:
Bug 168939: Make ImageDiff stand-alone
https://bugs.webkit.org/show_bug.cgi?id=168939

Attachment 308978: Patch

https://bugs.webkit.org/attachment.cgi?id=308978&action=review




--- Comment #18 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 308978
  --> https://bugs.webkit.org/attachment.cgi?id=308978
Patch

A few comments on the changes.

Generally, yes, this is meant to be built only on Mac.	But, I'm not going to
specifically disable building it for other platforms (namely iOS simulator) so
that we don't break anything while I'm making these changes.

First, I moved over some of the CMake stuff.  That does need to be done since
the next patch will move ImageDiff out of DumpRenderTree entirely.

Second, along with DebugRelease.xcconfig, Base.xcconfig needed to be moved as
well.  Both had some WebKit references in them, those were removed.

Lastly, I don't think your comment about OTHER_CPLUSPLUSFLAGS is correct.  Or
at least, reading through our other config files, it doesn't seem to be
correct.  Looking at something like WebKitTestRunnerApp.xcconfig, it seems that
a variable without [platform*] applies to all platforms.  Otherwise, to point
back to the WebKitTestRunnerApp example, that configuration file would not link
WebKitTestRunnerApp against the required frameworks.