[webkit-reviews] review granted: [Bug 171292] [MediaStream] Allow host application to enable/disable media capture : [Attachment 308966] Proposed patch.

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 171292: [MediaStream] Allow host application to enable/disable media
capture
https://bugs.webkit.org/show_bug.cgi?id=171292

Attachment 308966: Proposed patch.

https://bugs.webkit.org/attachment.cgi?id=308966&action=review




--- Comment #4 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 308966
  --> https://bugs.webkit.org/attachment.cgi?id=308966
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=308966&action=review

> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:129
> -    m_ended = true;
> +    if (mode == StopMode::Silently)
> +	   m_ended = true;
> +
> +
>      m_private->endTrack();
> +    m_ended = true;

Nit: I think this may deserve a comment; the side effects here are subtle, and
it would be a shame if a future developer (e.g., me) accidentally broke this.