[webkit-reviews] review granted: [Bug 171585] [WK2] Add support for keeping the selection in a focused editable element when dragging begins : [Attachment 308926] Handle multiple dragged content ranges in RenderText

[bugzilla-daemon at webkit.org]

Beth Dakin <bdakin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 171585: [WK2] Add support for keeping the selection in a focused editable
element when dragging begins
https://bugs.webkit.org/show_bug.cgi?id=171585

Attachment 308926: Handle multiple dragged content ranges in RenderText

https://bugs.webkit.org/attachment.cgi?id=308926&action=review




--- Comment #4 from Beth Dakin <bdakin at apple.com> ---
Comment on attachment 308926
  --> https://bugs.webkit.org/attachment.cgi?id=308926
Handle multiple dragged content ranges in RenderText

View in context: https://bugs.webkit.org/attachment.cgi?id=308926&action=review

r=me, though it would be good to get Simon, Myles, Dean, or Alan to take a look
at some point.

> Source/WebCore/dom/DocumentMarkerController.cpp:142
> +	   DocumentMarker::DraggedContentData draggedContentData {
markedText.node() };

Could textPiece ever be null? If not, this is okay. If so, you should add a
null check.