[webkit-reviews] review granted: [Bug 167473] Uncaught Exception: Can't make a ContentView for an unknown representedObject of type: IndexedDatabase : [Attachment 308868] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 167473: Uncaught Exception: Can't make a ContentView for an unknown
representedObject of type: IndexedDatabase
https://bugs.webkit.org/show_bug.cgi?id=167473

Attachment 308868: Patch

https://bugs.webkit.org/attachment.cgi?id=308868&action=review




--- Comment #24 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 308868
  --> https://bugs.webkit.org/attachment.cgi?id=308868
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308868&action=review

Looks good! r=me, with comments.

> Source/WebInspectorUI/UserInterface/Views/ContentView.css:45
> +}

This rule should go in IndexedDatabaseContentView.css. Headers will be nice to
have when we have multiple sections in a ContentView.

> Source/WebInspectorUI/UserInterface/Views/ContentView.css:52
> +    width: auto;

Much nicer than having a fixed width.

> Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseContentView.js:47
> +    {

Can the represented object change during the lifetime of the view? If not this
should move to constructor.