[webkit-reviews] review granted: [Bug 171607] Handle KVO updating of the "hasOnlySecureContent" before a page results in an HTTP auth challenge : [Attachment 308930] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 3 11:20:13 PDT 2017


Andy Estes <aestes at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 171607: Handle KVO updating of the "hasOnlySecureContent" before a page
results in an HTTP auth challenge
https://bugs.webkit.org/show_bug.cgi?id=171607

Attachment 308930: Patch

https://bugs.webkit.org/attachment.cgi?id=308930&action=review




--- Comment #2 from Andy Estes <aestes at apple.com> ---
Comment on attachment 308930
  --> https://bugs.webkit.org/attachment.cgi?id=308930
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308930&action=review

> Source/WebKit2/UIProcess/PageLoadState.cpp:209
> +    if (data.state == State::Provisional)
> +	   return WebCore::protocolIs(data.provisionalURL, "https");

Feels like a blank line belongs at the end of this.


More information about the webkit-reviews mailing list