[webkit-reviews] review granted: [Bug 171350] [WebCrypto] Add an api test for testing wrapping/unwrapping serialized crypto keys : [Attachment 308303] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 171350: [WebCrypto] Add an api test for testing wrapping/unwrapping
serialized crypto keys
https://bugs.webkit.org/show_bug.cgi?id=171350

Attachment 308303: Patch

https://bugs.webkit.org/attachment.cgi?id=308303&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 308303
  --> https://bugs.webkit.org/attachment.cgi?id=308303
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308303&action=review

This looks good, but I think your test case is wrong in the openRequest.onerror
handler. Can you please fix before landing?

> Tools/TestWebKitAPI/Tests/WebKit2/navigation-client-default-crypto.html:49
> +	   finishJSTest();

There are no definitions for "testFailed" or "finishJSTest" in TestWebKitAPI --
I'm surprised this doesn't create an error when you run.

Please remove these lines and switch to "alert("FAIL")" or something for these
failure case.