[webkit-reviews] review denied: [Bug 171595] [GTK] Bump GStreamer version to 1.10.4 in jhbuild : [Attachment 308892] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 171595: [GTK] Bump GStreamer version to 1.10.4 in jhbuild
https://bugs.webkit.org/show_bug.cgi?id=171595

Attachment 308892: Patch

https://bugs.webkit.org/attachment.cgi?id=308892&action=review




--- Comment #6 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 308892
  --> https://bugs.webkit.org/attachment.cgi?id=308892
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308892&action=review

> Tools/ChangeLog:17
> +	   * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch:
Removed.
> +	   *
gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_gene
rate_k.patch: Removed.
> +	   *
gtk/patches/gst-plugins-good-0001-rtpbin-pipeline-gets-an-EOS-when-any-rtpsourc
es-byes.patch: Removed.
> +	   *
gtk/patches/gst-plugins-good-0002-rtpbin-avoid-generating-errors-when-rtcp-mess
ages-ar.patch: Removed.
> +	   *
gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed.
> +	   *
gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protectio
n.patch: Removed.
> +	   *
gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-
fr.patch: Removed.
> +	   * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
Removed.
> +	   *
gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch
: Removed.

Please, check if these patches are present in 1.10.4 before removing them. As I
said at least two of them are still needed. Please keep me posted.

> Tools/gtk/jhbuild.modules:-361
> -  <autotools id="orc" autogenargs="--disable-gtk-doc"
autogen-sh="configure">
> -    <branch module="orc/orc-0.4.17.tar.gz" version="0.4.17"
> -	       repo="gstreamer"
> -	      
hash="sha256:4fc7cca48c59fff23afee78fb642cdbde001f56401c8f47b95a16578d1d5d7e8"
> -	       md5sum="af1bf3dab9e69f3c36f389285e2a12a1"/>
> -  </autotools>

Why are you removing orc?