[webkit-reviews] review granted: [Bug 171527] How we build polymorphic cases is wrong when making a call from Wasm : [Attachment 308798] patch

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 171527: How we build polymorphic cases is wrong when making a call from
Wasm
https://bugs.webkit.org/show_bug.cgi?id=171527

Attachment 308798: patch

https://bugs.webkit.org/attachment.cgi?id=308798&action=review




--- Comment #6 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 308798
  --> https://bugs.webkit.org/attachment.cgi?id=308798
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308798&action=review

A few comments, but overall looks good.

> Source/JavaScriptCore/wasm/WasmBinding.cpp:128
> +    if (!Options::useCallICsForWebAssemblyToJSCalls()) {

This versus the code below are kinda hard to tell apart. Aren't the mostly
similar? Could you pull the common bits out, or is it too weird?

> Source/JavaScriptCore/wasm/WasmBinding.cpp:136
> +	   jit.subPtr(MacroAssembler::TrustedImm32(16),
MacroAssembler::stackPointerRegister);

Why 16 instead of 8?