[webkit-reviews] review requested: [Bug 171571] [Win] Remove redundant macros that are set in the CMake config : [Attachment 308851] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 2 14:40:21 PDT 2017


Don Olmstead <don.olmstead at am.sony.com> has asked  for review:
Bug 171571: [Win] Remove redundant macros that are set in the CMake config
https://bugs.webkit.org/show_bug.cgi?id=171571

Attachment 308851: Patch

https://bugs.webkit.org/attachment.cgi?id=308851&action=review




--- Comment #1 from Don Olmstead <don.olmstead at am.sony.com> ---
Created attachment 308851

  --> https://bugs.webkit.org/attachment.cgi?id=308851&action=review

Patch

Removes any additions of WINVER, _WIN32_WINNT, and NOMINMAX set within WebKit.

Removes the _CRT_RAND_S value as that does not appear to be relevant anymore.

Also removes blocks of code where WINVER is less than the supported value.

Had to remove the definition of _WIN32_WINNT when building ANGLE as it would
not compile otherwise.


More information about the webkit-reviews mailing list