[webkit-reviews] review denied: [Bug 171565] [WK2] Add SPI to query if a web process was terminated due to resource limits : [Attachment 308846] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 2 14:10:30 PDT 2017


Sam Weinig <sam at webkit.org> has denied Chris Dumez <cdumez at apple.com>'s request
for review:
Bug 171565: [WK2] Add SPI to query if a web process was terminated due to
resource limits
https://bugs.webkit.org/show_bug.cgi?id=171565

Attachment 308846: Patch

https://bugs.webkit.org/attachment.cgi?id=308846&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 308846
  --> https://bugs.webkit.org/attachment.cgi?id=308846
Patch

Seems like this should just be a parameter passed to processDidCrash (or maybe
a WKErrorRef?).  Also, please add an API test for this (you can at least test
the termination reason for a simulated crash).

That said, what is the use case for differentiating between different types of
crashes?


More information about the webkit-reviews mailing list