[webkit-reviews] review granted: [Bug 171554] JSC C API should expose GC marking constraints and weak references : [Attachment 308829] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 171554: JSC C API should expose GC marking constraints and weak references
https://bugs.webkit.org/show_bug.cgi?id=171554

Attachment 308829: the patch

https://bugs.webkit.org/attachment.cgi?id=308829&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 308829
  --> https://bugs.webkit.org/attachment.cgi?id=308829
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308829&action=review

r=me

> Source/JavaScriptCore/API/JSMarkingConstraintPrivate.h:47
> +JS_EXPORT void JSContextGroupRegisterMarkingConstraint(JSContextGroupRef,
JSMarkingConstraint, void *userData);

Usually we would do this as a pair of add/remove APIs:
JSContextGroupAddMarkingConstraint, JSContextGroupRemoveMarkingConstraint.