[webkit-reviews] review granted: [Bug 170747] Link preload HTMLPreloadScanner support : [Attachment 306857] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Yoav Weiss <yoav at yoav.ws>'s
request for review:
Bug 170747: Link preload HTMLPreloadScanner support
https://bugs.webkit.org/show_bug.cgi?id=170747

Attachment 306857: Patch

https://bugs.webkit.org/attachment.cgi?id=306857&action=review




--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 306857
  --> https://bugs.webkit.org/attachment.cgi?id=306857
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306857&action=review

> Source/WebCore/html/parser/HTMLPreloadScanner.cpp:149
> +	   std::optional<CachedResource::Type> type = resourceType();

Use auto maybe?

> LayoutTests/http/tests/preload/preloadscanner_download_resources.html:7
> +    shouldBeTrue("internals.isPreloaded('../resources/dummy.js');");

Can you exit early if window.intrrnals is undefined?

> LayoutTests/http/tests/preload/preloadscanner_download_resources.html:8
> +    shouldBeTrue("internals.isPreloaded('../resources/dummy.css');");

Exit with a proper message..,