[webkit-reviews] review granted: [Bug 170767] [GStreamer] Dailymotion live stream videos don't play : [Attachment 308811] Rebased patch

[bugzilla-daemon at webkit.org]

Sergio Villar Senin <svillar at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 170767: [GStreamer] Dailymotion live stream videos don't play
https://bugs.webkit.org/show_bug.cgi?id=170767

Attachment 308811: Rebased patch

https://bugs.webkit.org/attachment.cgi?id=308811&action=review




--- Comment #3 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 308811
  --> https://bugs.webkit.org/attachment.cgi?id=308811
Rebased patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308811&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:909
> +	   priv->redirectedURI = WTFMove(resolvedURI);

This resolved/redirected naming is a bit confusing.

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:956
> +

I think this chunk of code deserves an explanation, it's pretty clear what it
does but not why we need to do this.