[webkit-reviews] review granted: [Bug 171363] Web Inspector: ASSERT(!m_startedComposite) fails when recording on non-Cocoa Timeline : [Attachment 308327] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 171363: Web Inspector: ASSERT(!m_startedComposite) fails when recording on
non-Cocoa Timeline
https://bugs.webkit.org/show_bug.cgi?id=171363

Attachment 308327: Patch

https://bugs.webkit.org/attachment.cgi?id=308327&action=review




--- Comment #4 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 308327
  --> https://bugs.webkit.org/attachment.cgi?id=308327
Patch

r=me.

I don't have an easy way to test this, but it seems clear that the second time
willComposite is called (and every time after) it will assert, since
didComposite is never called. Ross's patch matches the guards around the
creation of the run loop observation points and looks correct.