[webkit-reviews] review granted: [Bug 171416] RejectedPromiseTracker should produce better callstacks and avoid capturing callstacks unless there is a debugger/inspector : [Attachment 308645] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 171416: RejectedPromiseTracker should produce better callstacks and avoid
capturing callstacks unless there is a debugger/inspector
https://bugs.webkit.org/show_bug.cgi?id=171416

Attachment 308645: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=308645&action=review




--- Comment #17 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 308645
  --> https://bugs.webkit.org/attachment.cgi?id=308645
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=308645&action=review

> Source/WebCore/ChangeLog:22
> +	   new stack since the try/catch. Instead, we want the stack from
before

did you mean to say "since" here?

> Source/WebCore/ChangeLog:28
> +	   Switch to a pointer since the staack could be empty.

staack =>stack

> Source/WebCore/dom/RejectedPromiseTracker.cpp:114
> +	   if (exception->value() == reason)
> +	       return createScriptCallStackFromException(&state, exception,
ScriptCallStack::maxCallStackSizeToCapture);

Don't we only want to do this if the debugger is open?