[webkit-reviews] review granted: [Bug 171497] Ensure RealtimeOutgoingVideoSource sends a black frame when its related source is muted : [Attachment 308729] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 171497: Ensure RealtimeOutgoingVideoSource sends a black frame when its
related source is muted
https://bugs.webkit.org/show_bug.cgi?id=171497

Attachment 308729: Patch

https://bugs.webkit.org/attachment.cgi?id=308729&action=review




--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 308729
  --> https://bugs.webkit.org/attachment.cgi?id=308729
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308729&action=review

> Source/WebCore/ChangeLog:11
> +	   VideoToolBox sometimes do not output a frame until receveing the
other.

Nit: "sometimes do not" -> "sometimes does not"

"until receveing the other -> "until it receives another"

> Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:84
> +	   sendBlackFrame();
> +	   // FIXME: We should not need to send two black frames but VTB
requires that so we are sure a black frame is sent over the wire.
> +	   m_blackFrameTimer.startOneShot(0_s);

Nit: this could be put into a helper function since it is repeated in
sourceEnabledChanged.

> Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.h:95
> +    uint32_t m_width { 0 };
> +    uint32_t m_height { 0 };

Nit: can you use an IntSize here?