[webkit-reviews] review granted: [Bug 171403] Add audio device change notifications to AudioSession. : [Attachment 308745] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 171403: Add audio device change notifications to AudioSession.
https://bugs.webkit.org/show_bug.cgi?id=171403

Attachment 308745: Patch

https://bugs.webkit.org/attachment.cgi?id=308745&action=review




--- Comment #17 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 308745
  --> https://bugs.webkit.org/attachment.cgi?id=308745
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308745&action=review

>
Source/WebCore/platform/audio/mac/AudioSessionMac.mmSource/WebCore/platform/aud
io/mac/AudioSessionMac.cpp:266
> +    if (m_private->observers.size() > 1)
>	   return;

Why "m_private->observers.size() > 1", should it be " > 0"?