[webkit-reviews] review denied: [Bug 171467] Async image decoding should be disabled for snapshots, printing and preview : [Attachment 308625] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 171467: Async image decoding should be disabled for snapshots, printing and
preview
https://bugs.webkit.org/show_bug.cgi?id=171467

Attachment 308625: Patch

https://bugs.webkit.org/attachment.cgi?id=308625&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 308625
  --> https://bugs.webkit.org/attachment.cgi?id=308625
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308625&action=review

> Source/WebCore/page/FrameView.cpp:4410
> +	   frame().settings().setLargeImageAsyncDecodingEnabled(false);

We don't generally toggle settings as a way of setting temporary runtime state;
toggling settings can have side effects like all-frame style recalcs.

Why not just test (view().frameView().paintBehavior() &
PaintBehaviorFlattenCompositingLayers) as we do in RenderBox::paintMaskImages?