[webkit-reviews] review granted: [Bug 170378] WebAssembly: webAssemblyB3OptimizationLevel should use defaultB3OptLevel by default : [Attachment 306037] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 170378: WebAssembly: webAssemblyB3OptimizationLevel should use
defaultB3OptLevel by default
https://bugs.webkit.org/show_bug.cgi?id=170378

Attachment 306037: Patch

https://bugs.webkit.org/attachment.cgi?id=306037&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 306037
  --> https://bugs.webkit.org/attachment.cgi?id=306037
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306037&action=review

> Source/JavaScriptCore/wasm/WasmB3IRGenerator.h:51
> +Expected<std::unique_ptr<WasmInternalFunction>, String>
parseAndCompile(CompilationContext&, const uint8_t*, size_t, const Signature&,
Vector<UnlinkedWasmToWasmCall>&, const ModuleInformation&, const
Vector<SignatureIndex>&, MemoryMode, unsigned optLevel);

You don't need to make the callers of this function pass in a value?