[webkit-reviews] review granted: [Bug 170261] WebAssembly: Make our calls out to JS PIC friendly : [Attachment 306034] patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 170261: WebAssembly: Make our calls out to JS PIC friendly
https://bugs.webkit.org/show_bug.cgi?id=170261

Attachment 306034: patch

https://bugs.webkit.org/attachment.cgi?id=306034&action=review




--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 306034
  --> https://bugs.webkit.org/attachment.cgi?id=306034
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306034&action=review

r=me.

> Source/JavaScriptCore/wasm/js/JSWebAssemblyCodeBlock.h:120
> +    static ptrdiff_t offsetOfImportWasmToJSStub(unsigned calleeCount,
unsigned importIndex)
> +    {
> +	   return offsetOfCallees()
> +	       + (sizeof(WriteBarrier<JSWebAssemblyCallee>) * calleeCount * 2)
> +	       + (sizeof(void*) * importIndex);
> +    }
> +

oh man, this is brutal.