[webkit-reviews] review granted: [Bug 170316] WebAssembly: Ref count Signature and SignatureInformation should not care about VM : [Attachment 306001] patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 170316: WebAssembly: Ref count Signature and SignatureInformation should
not care about VM
https://bugs.webkit.org/show_bug.cgi?id=170316

Attachment 306001: patch

https://bugs.webkit.org/attachment.cgi?id=306001&action=review




--- Comment #10 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 306001
  --> https://bugs.webkit.org/attachment.cgi?id=306001
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306001&action=review

r=me

> Source/JavaScriptCore/wasm/WasmSignature.cpp:72
> +    void* memory = Signature::operator new (allocatedSize(argumentCount));
> +    Signature* result = new (memory) Signature(argumentCount);

Why not use the NotNull flag?