[webkit-reviews] review granted: [Bug 170186] webkitpy: Add target host concept : [Attachment 305981] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 170186: webkitpy: Add target host concept
https://bugs.webkit.org/show_bug.cgi?id=170186

Attachment 305981: Patch

https://bugs.webkit.org/attachment.cgi?id=305981&action=review




--- Comment #8 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 305981
  --> https://bugs.webkit.org/attachment.cgi?id=305981
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305981&action=review

> Tools/Scripts/webkitpy/common/system/filesystem.py:315
> +	   """Returns a path from the base host localized for this host.  By
default,

Please don't use French spaces.

> Tools/Scripts/webkitpy/common/system/filesystem.py:320
> +	   """Moves a file from this host to the base host.  Be default, this
host

Ditto. Typo: Be default.

It may be better to have a copy operation, as move can't be atomic in he
general case anyway. As far as I understand, we don't need to copy or move for
Simulator much anyway.

> Tools/Scripts/webkitpy/common/system/filesystem.py:325
> +	   """Moves a file from the base host to this host.  Be default, this
host

Ditto.

> Tools/Scripts/webkitpy/port/darwin.py:157
> +    def sample_file_path(self, name, pid, dir):

dir -> directory

> Tools/Scripts/webkitpy/port/darwin.py:160
> +    def spindump_file_path(self, name, pid, dir):

Ditto.