[webkit-reviews] review denied: [Bug 170351] JavaScriptCore: Do not use BLX for immediates (ARM-32) : [Attachment 305990] The patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 31 13:08:09 PDT 2017


Filip Pizlo <fpizlo at apple.com> has denied  review:
Bug 170351: JavaScriptCore: Do not use BLX for immediates (ARM-32)
https://bugs.webkit.org/show_bug.cgi?id=170351

Attachment 305990: The patch

https://bugs.webkit.org/attachment.cgi?id=305990&action=review




--- Comment #3 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 305990
  --> https://bugs.webkit.org/attachment.cgi?id=305990
The patch

Please conditionalize this change for not-iOS.	On iOS, it's correct to use
blx.


More information about the webkit-reviews mailing list