[webkit-reviews] review requested: [Bug 170316] WebAssembly: Ref count Signature and SignatureInformation should not care about VM : [Attachment 306001] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 31 12:33:03 PDT 2017


Saam Barati <sbarati at apple.com> has asked  for review:
Bug 170316: WebAssembly: Ref count Signature and SignatureInformation should
not care about VM
https://bugs.webkit.org/show_bug.cgi?id=170316

Attachment 306001: patch

https://bugs.webkit.org/attachment.cgi?id=306001&action=review




--- Comment #9 from Saam Barati <sbarati at apple.com> ---
Created attachment 306001

  --> https://bugs.webkit.org/attachment.cgi?id=306001&action=review

patch

Addressed most comments. I also switched to using Ref instead of RefPtr. There
is no reason a signature should ever be null. This would be very wrong.


More information about the webkit-reviews mailing list