[webkit-reviews] review denied: [Bug 170292] Web Inspector: RTL: results in Search navigation sidebar have misplaced highlights : [Attachment 305886] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has denied Brian Burg <bburg at apple.com>'s
request for review:
Bug 170292: Web Inspector: RTL: results in Search navigation sidebar have
misplaced highlights
https://bugs.webkit.org/show_bug.cgi?id=170292

Attachment 305886: Patch

https://bugs.webkit.org/attachment.cgi?id=305886&action=review




--- Comment #6 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 305886
  --> https://bugs.webkit.org/attachment.cgi?id=305886
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305886&action=review

> Source/WebInspectorUI/UserInterface/Views/SearchIcons.css:50
> +.source-code-match .icon {

Nice cleanup, so tired of seeing .yet-another-icon .icon everywhere.

> Source/WebInspectorUI/UserInterface/Views/SearchResultTreeElement.js:42
> +	   const charactersToShowBeforeSearchMatch = isRTL ? 20 : 15;

Why is this changing to 20? It feels wrong presenting less/different data in
RTL.

> Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.css:57
> +    text-align: right;

This looks wrong. Search results are now right aligned when viewed in LTR.