[webkit-reviews] review denied: [Bug 170157] [WebRTC][OpenWebRTC] Add support for SDP BUNDLE ("a:group:BUNDLE" and "a=bundle-only" lines) : [Attachment 305587] Patch

[bugzilla-daemon at webkit.org]

Alejandro G. Castro <alex at igalia.com> has denied Carlos Alberto Lopez Perez
<clopez at igalia.com>'s request for review:
Bug 170157: [WebRTC][OpenWebRTC] Add support for SDP BUNDLE ("a:group:BUNDLE"
and "a=bundle-only" lines)
https://bugs.webkit.org/show_bug.cgi?id=170157

Attachment 305587: Patch

https://bugs.webkit.org/attachment.cgi?id=305587&action=review




--- Comment #6 from Alejandro G. Castro <alex at igalia.com> ---
Comment on attachment 305587
  --> https://bugs.webkit.org/attachment.cgi?id=305587
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305587&action=review

> Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:162
> +    configurationSnapshot->m_bundlePolicy = m_bundlePolicy;

Should we do the same in the createAnswer method?

> Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:605
> +    m_bundlePolicy = configuration.bundlePolicy;

Can we avoid having a m_bundlePolicy attribute in the peerConnection class and
just use the sessionConfiguration value. I mean, we can use the bundlePolicy
inside the endpoint configuration when creating the sessionConfiguration we are
going to use for the offer or the answer.

> Source/WebCore/platform/mediastream/MediaEndpointSessionConfiguration.h:61
> +    PeerConnectionStates::BundlePolicy m_bundlePolicy =
PeerConnectionStates::BundlePolicy::Balanced;
> +

We can add API here to get and set the bundle instead of making it public.