[webkit-reviews] review granted: [Bug 170267] Support tvOS and watchOS in webkitdirs.pm : [Attachment 305823] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 29 20:35:13 PDT 2017
Alexey Proskuryakov <ap at webkit.org> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 170267: Support tvOS and watchOS in webkitdirs.pm
https://bugs.webkit.org/show_bug.cgi?id=170267
Attachment 305823: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=305823&action=review
--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 305823
--> https://bugs.webkit.org/attachment.cgi?id=305823
Proposed patch
View in context: https://bugs.webkit.org/attachment.cgi?id=305823&action=review
> Tools/Scripts/webkitdirs.pm:469
> + if (checkForArgumentAndRemoveFromARGV("--tv-device")) {
I wonder if it would be better to have "os" in the option name, for consistency
with ios.
> Tools/Scripts/webkitdirs.pm:1353
> + return isIOSWebKit() || isTVOSWebKit() || isWATCHOSWebKit();
Double space here.
More information about the webkit-reviews
mailing list