[webkit-reviews] review granted: [Bug 170266] WebAssembly: B3IRGenerator should pool constants : [Attachment 305820] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 170266: WebAssembly: B3IRGenerator should pool constants
https://bugs.webkit.org/show_bug.cgi?id=170266

Attachment 305820: Patch

https://bugs.webkit.org/attachment.cgi?id=305820&action=review




--- Comment #2 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 305820
  --> https://bugs.webkit.org/attachment.cgi?id=305820
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305820&action=review

seems legit

> Source/JavaScriptCore/b3/B3Procedure.h:121
> +    // bits is a bitwise_cast of the constant you want.
> +    Value* addConstant(Origin, Type, uint64_t bits);

Nice