[webkit-reviews] review granted: [Bug 170144] webkitpy: Standardize web-server port definitions : [Attachment 305749] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 29 10:55:59 PDT 2017

Daniel Bates <dbates at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 170144: webkitpy: Standardize web-server port definitions

Attachment 305749: Patch


--- Comment #8 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 305749
  --> https://bugs.webkit.org/attachment.cgi?id=305749

View in context: https://bugs.webkit.org/attachment.cgi?id=305749&action=review


> Tools/ChangeLog:9
> +	   Default web-server ports should be declared in global variables.

Is this description up-to-date?

> Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py:-48

I am assuming that this was unused before his patch as I did not see any caller
updated in this patch.

More information about the webkit-reviews mailing list