[webkit-reviews] review granted: [Bug 170184] Web Inspector: tabbing in Styles sidebar is broken when additional ":" and "; " are in the property value : [Attachment 305618] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 170184: Web Inspector: tabbing in Styles sidebar is broken when additional
":" and ";" are in the property value
https://bugs.webkit.org/show_bug.cgi?id=170184

Attachment 305618: Patch

https://bugs.webkit.org/attachment.cgi?id=305618&action=review




--- Comment #2 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 305618
  --> https://bugs.webkit.org/attachment.cgi?id=305618
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305618&action=review

Since we have so many editing issues in the styles sidebar, I think we should
break out the range matching into a utility method (that handles plain text,
not CodeMirror) so we can write tests.

>
Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:408
> +    _rangeForNextNameOrValue(codeMirror, cursor, text) {

Style: put open brace on newline.