[webkit-reviews] review granted: [Bug 168660] REGRESSION(~r212322): LayoutTest media/track/track-cue-container-rendering-position.html is a flaky timeout : [Attachment 305729] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 29 06:43:58 PDT 2017


Eric Carlson <eric.carlson at apple.com> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 168660: REGRESSION(~r212322): LayoutTest
media/track/track-cue-container-rendering-position.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=168660

Attachment 305729: Patch

https://bugs.webkit.org/attachment.cgi?id=305729&action=review




--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 305729
  --> https://bugs.webkit.org/attachment.cgi?id=305729
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305729&action=review

> LayoutTests/media/track/track-cue-container-rendering-position.html:25
> +	       } catch (exception) {

I think it would be better to try this a finite number of times and fail with
an error message instead of having the test timeout in the event of an error.


More information about the webkit-reviews mailing list