[webkit-reviews] review granted: [Bug 170217] WebAssembly: We should have Origins : [Attachment 305681] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 170217: WebAssembly: We should have Origins
https://bugs.webkit.org/show_bug.cgi?id=170217

Attachment 305681: Patch

https://bugs.webkit.org/attachment.cgi?id=305681&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 305681
  --> https://bugs.webkit.org/attachment.cgi?id=305681
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305681&action=review

r=me if it builds.

> Source/JavaScriptCore/ChangeLog:9
> +	   This patch adds wasm origins for B3::Values, called OpcodeOrigin.
Currently,
> +	   OpcodeOrigin just tracks the original opcode and the location of
that opcode.

I think it would be nice to have the sample output after this paragraph.