[webkit-reviews] review granted: [Bug 170219] WebAssembly: option to crash if no fast memory is available : [Attachment 305680] patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted JF Bastien <jfbastien at apple.com>'s
request for review:
Bug 170219: WebAssembly: option to crash if no fast memory is available
https://bugs.webkit.org/show_bug.cgi?id=170219

Attachment 305680: patch

https://bugs.webkit.org/attachment.cgi?id=305680&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 305680
  --> https://bugs.webkit.org/attachment.cgi?id=305680
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305680&action=review

r=me

> Source/JavaScriptCore/wasm/WasmMemory.cpp:124
> +    if (!fastMemoryEnabled())

nit: if (UNLIKELY(...

> Source/JavaScriptCore/wasm/WasmMemory.cpp:128
> +    if (!vm.getCTIStub(throwExceptionFromWasmThunkGenerator).size())

nit: if (UNLIKELY(...

> Source/JavaScriptCore/wasm/WasmMemory.cpp:129
> +	   goto fail;

"goto"!  One of my favorite coding constructs that gets so little use because
peeps don't know how to use it right, and fear it.

> Source/JavaScriptCore/wasm/WasmMemory.cpp:139
> +	   if (dequeFastMemory())

nit: if (LIKELY(...

> Source/JavaScriptCore/wasm/WasmMemory.cpp:153
> +    if (memory)

nit: if (LIKELY(memory))