[webkit-reviews] review granted: [Bug 170216] Add some tests that dump the touch event regions with various content configurations : [Attachment 305678] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 170216: Add some tests that dump the touch event regions with various
content configurations
https://bugs.webkit.org/show_bug.cgi?id=170216

Attachment 305678: Patch

https://bugs.webkit.org/attachment.cgi?id=305678&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 305678
  --> https://bugs.webkit.org/attachment.cgi?id=305678
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305678&action=review

>
LayoutTests/fast/events/touch/ios/touch-event-regions/resources/touch-regions-h
elper.js:11
> +	   result += rect.left + ', ' + rect.top + ' - ' + rect.right + ', ' +
rect.bottom;

result =+ `${rect.left}, ${rect.left} - ${rect.right}, ${rect.bottom}`;

and maybe

result =+ `${i ? '\n'}${rect.left}, ${rect.left} - ${rect.right},
${rect.bottom}`;

and then maybe you should just do a map and join

rects.map((rect) => `${rect.left}, ${rect.left} - ${rect.right},
${rect.bottom}`).join('\n')